Skip to content

opentelemetry-sdk: fix typing issues for metrics instruments#5082

Merged
xrmx merged 3 commits intoopen-telemetry:mainfrom
xrmx:fix-metrics-instrument-sdk-typing
Apr 20, 2026
Merged

opentelemetry-sdk: fix typing issues for metrics instruments#5082
xrmx merged 3 commits intoopen-telemetry:mainfrom
xrmx:fix-metrics-instrument-sdk-typing

Conversation

@xrmx
Copy link
Copy Markdown
Contributor

@xrmx xrmx commented Apr 13, 2026 •
edited by MikeGoldsmith
Loading

Description

This solves 19 issues reported by pyright but not does not make any module clean so list of the excluded files is not updated.

Refs #1608

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@xrmx xrmx added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 13, 2026
@xrmx xrmx requested a review from a team as a code owner April 13, 2026 11:11
MikeGoldsmith
MikeGoldsmith approved these changes Apr 13, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@MikeGoldsmith MikeGoldsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@github-project-automation github-project-automation Bot moved this to Approved PRs in Python PR digest Apr 13, 2026
xrmx
xrmx commented Apr 14, 2026
View reviewed changes
Comment thread opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/instrument.py Outdated
aabmass
aabmass reviewed Apr 14, 2026
View reviewed changes
Comment thread opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/instrument.py Outdated
Comment thread opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/instrument.py Outdated
@xrmx xrmx mentioned this pull request Apr 15, 2026
Merged
11 tasks
@xrmx xrmx requested a review from aabmass April 16, 2026 08:02
@xrmx xrmx enabled auto-merge (squash) April 20, 2026 13:58
@xrmx xrmx merged commit 90c0319 into open-telemetry:main Apr 20, 2026
465 checks passed
@github-project-automation github-project-automation Bot moved this from Approved PRs to Done in Python PR digest Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aabmass aabmass aabmass approved these changes

@MikeGoldsmith MikeGoldsmith MikeGoldsmith approved these changes

@tammy-baylis-swi tammy-baylis-swi tammy-baylis-swi approved these changes

Assignees

No one assigned

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

Python PR digest
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xrmx @aabmass @MikeGoldsmith @tammy-baylis-swi